New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update table in README #12

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@chharvey
Copy link

chharvey commented Feb 3, 2019

I added "Resolve Value" and "Reject Value" columns to the table for clarity. Also switched rows around, for easier pattern recognition.

chharvey added some commits Feb 3, 2019

@ljharb
Copy link
Member

ljharb left a comment

Feel free not to take the exact suggestions, but “resolved” isn’t the correct term - it’s “fulfilled”, and a rejected promise has a “reason” not a “value”.

Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
@gibson042
Copy link
Contributor

gibson042 left a comment

I think this change would make the motivation table more complete but less clear. The point is to show how this proposal fills a gap, but that gets lost in the details of much less relevant settlement result values.

@mathiasbynens

This comment has been minimized.

Copy link
Member

mathiasbynens commented Feb 4, 2019

Thanks for the suggestion, @chharvey!

As @gibson042 points out, the table is only intended to convey the gap filled by the Promise.any proposal, and not to be exhaustively informative. As such, I’m gonna close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment