Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove AggregateError.prototype.errors #41

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@bakkot
Copy link
Collaborator

commented Oct 2, 2019

I very strongly agree with @ljharb's comment that we should not introduce a mutable data property on a prototype. We can just not do that instead.

@bakkot bakkot requested review from mathiasbynens and chicoxyzzy Oct 2, 2019
@mathiasbynens mathiasbynens merged commit 2ed2847 into master Oct 2, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@mathiasbynens mathiasbynens deleted the no-mutable-proto branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.