New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the motivation for isSet? #5

Closed
gsathya opened this Issue Jan 5, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@gsathya
Member

gsathya commented Jan 5, 2018

Generally there is really no brand checking in JavaScript (except for isArray, which I've heard was a mistake). What's the motivation for Set.isSet?

@Ginden

This comment has been minimized.

Show comment
Hide comment
@Ginden

Ginden Jan 5, 2018

Collaborator

@gsathya It was added as analog for Array.isArray and it's featured in many libraries adding Sets (eg. Immutable.js). Though, I'm not emotionally attached to it.

Collaborator

Ginden commented Jan 5, 2018

@gsathya It was added as analog for Array.isArray and it's featured in many libraries adding Sets (eg. Immutable.js). Though, I'm not emotionally attached to it.

@Ginden Ginden added the question label Jan 5, 2018

@gsathya

This comment has been minimized.

Show comment
Hide comment
@gsathya

gsathya Jan 5, 2018

Member

What's the main use case for this? Array.isArray was mainly added for concat and consistency reasons. isSet fits better with the Builtins.is proposal, IMO.

Member

gsathya commented Jan 5, 2018

What's the main use case for this? Array.isArray was mainly added for concat and consistency reasons. isSet fits better with the Builtins.is proposal, IMO.

@Ginden Ginden closed this in ec18256 Jan 7, 2018

@Ginden

This comment has been minimized.

Show comment
Hide comment
@Ginden

Ginden Jan 7, 2018

Collaborator

@gsathya Removed in ec18256

Collaborator

Ginden commented Jan 7, 2018

@gsathya Removed in ec18256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment