New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec/polyfill #8

Merged
merged 1 commit into from Jan 7, 2018

Conversation

Projects
None yet
2 participants
@gsathya
Member

gsathya commented Jan 6, 2018

Spec changes

  • Fixed #6 (create a new set with items populated in both union and subtract)
  • Changed .subtract to return newSet after iteration is done
  • Use 'items' instead of 'iterables' to be more consistent

Polyfill changes

  • Added SpeciesConstructor, isObject, isCallable
  • Removed un spec'd xor
  • Updated subtract, union, removeElements

Added tests

Update spec/polyfill
Spec changes

- Fixed #6 (create a new set with items populated in both union and subtract)
- Changed .subtract to return newSet after iteration is done
- Use 'items' instead of 'iterables' to be more consistent

Polyfill changes

- Added SpeciesConstructor, isObject, isCallable
- Removed un spec'd xor
- Updated subtract, union, removeElements

Added tests
@gsathya

This comment has been minimized.

Show comment
Hide comment
@gsathya

gsathya Jan 6, 2018

Member

@Ginden -- The other methods in the polyfil need to be updated to match the spec text as well. Can you update them? I'll work on the spec text for Set#intersect, meanwhile.

Member

gsathya commented Jan 6, 2018

@Ginden -- The other methods in the polyfil need to be updated to match the spec text as well. Can you update them? I'll work on the spec text for Set#intersect, meanwhile.

@Ginden Ginden merged commit 80385ff into tc39:master Jan 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment