Remove undefined handling, remove shared-by-all-realms behavior #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After #60, we no longer need to handle `undefined` in the input template strings array. That's because a well-formed `raw` array can **only** contain strings (only the `cooked` array can contain `undefined`). Because we no longer have `undefined`s in our input, several of the AOs can remove branches for handling an empty block of lines.
bakkot
reviewed
Sep 13, 2022
spec.emu
Outdated
| @@ -120,7 +120,7 @@ markEffects: true | |||
| <h1> | |||
| DedentStringsArray ( | |||
| _template_: an ECMAScript language value, | |||
| ): either a normal completion containing a List of either String or *undefined*, or a throw completion | |||
| ): either a normal completion containing a List of String, or a throw completion | |||
There was a problem hiding this comment.
Suggested change
| ): either a normal completion containing a List of String, or a throw completion | |
| ): either a normal completion containing a List of Strings, or a throw completion |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #60, we no longer need to handle
undefinedin the input template strings array. That's because a well-formedrawarray can only contain strings (only thecookedarray can containundefined).Because we no longer have
undefineds in our input, several of the AOs can remove branches for handling an empty block of lines.This also fixes #64 by removing the "shared by all realms statement". That was an unintentional copy paste.