Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringIndexOf has an unused variable #22

Open
ljharb opened this issue Sep 2, 2019 · 0 comments

Comments

@ljharb
Copy link
Member

commented Sep 2, 2019

StringIndexOf sets, but does not use, the length variable.

It seems like perhaps the proposal should also include the changes to https://tc39.es/ecma262/#sec-string.prototype.indexof to use StringIndexOf, which would help review.

@ljharb ljharb referenced this issue Sep 2, 2019
4 of 8 tasks complete
mathiasbynens added a commit that referenced this issue Sep 2, 2019
Remove unused variable
Thanks to @ljharb for spotting this!

Ref. #22.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.