Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw when `flags` is `undefined` or `null` #26

Merged
merged 2 commits into from Oct 1, 2019

Conversation

@mathiasbynens
Copy link
Member

commented Oct 1, 2019

Per @msaboff’s feedback here: #17 (comment)

@mathiasbynens mathiasbynens changed the title Throw when `flags` is `undefined` Throw when `flags` is `undefined` or `null` Oct 1, 2019
@mathiasbynens mathiasbynens referenced this pull request Oct 1, 2019
7 of 7 tasks complete
@msaboff
msaboff approved these changes Oct 1, 2019
Copy link

left a comment

Looks good to me.

@ljharb
ljharb approved these changes Oct 1, 2019
@mathiasbynens mathiasbynens merged commit 4eae5a9 into master Oct 1, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@mathiasbynens mathiasbynens deleted the msaboff-review branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.