Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DateTime spec. #247

Open
wants to merge 5 commits into
base: main
from

Conversation

@Ms2ger
Copy link
Collaborator

Ms2ger commented Oct 31, 2019

No description provided.

spec/date.html Show resolved Hide resolved
spec/time.html Show resolved Hide resolved
spec/datetime.html Outdated Show resolved Hide resolved
spec/datetime.html Outdated Show resolved Hide resolved
@ryzokuken

This comment has been minimized.

Copy link
Member

ryzokuken commented Nov 1, 2019

@Ms2ger in light of #248, could you please rename DateTime.prototype.inZone to DateTime.prototype.inTimeZone? Thanks.

@Ms2ger Ms2ger force-pushed the datetime branch from adcca6b to 75f81e6 Nov 4, 2019
polyfill/lib/casts.mjs Show resolved Hide resolved
polyfill/lib/casts.mjs Show resolved Hide resolved
spec/datetime.html Show resolved Hide resolved
spec/datetime.html Show resolved Hide resolved
spec/datetime.html Show resolved Hide resolved
spec/datetime.html Outdated Show resolved Hide resolved
spec/datetime.html Show resolved Hide resolved
spec/datetime.html Show resolved Hide resolved
spec/datetime.html Outdated Show resolved Hide resolved
spec/datetime.html Outdated Show resolved Hide resolved
@Ms2ger Ms2ger force-pushed the datetime branch from 643078f to f9539dc Nov 11, 2019
polyfill/lib/casts.mjs Show resolved Hide resolved
@@ -129,10 +99,28 @@ export function CastDate(arg, aux) {
throw new RangeError(`invalid date ${arg}`);
}

export function TimeFromString(arg, Construct) {

This comment has been minimized.

Copy link
@ljharb

ljharb Nov 12, 2019

Member

super minor, but "Construct" seems like it's a verb, I'd expect "Constructor" or "C" here

spec/datetime.html Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.