Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] rename inZone to inTimeZone #248

Merged
merged 1 commit into from Nov 2, 2019

Conversation

@ryzokuken
Copy link
Member

ryzokuken commented Nov 1, 2019

Rename Absolute.prototype.inZone and DateTime.prototype.inZone to
Absolute.prototype.inTimeZone and DateTime.prototype.inTimeZone
respectively, since Temporal.TimeZone now exists.

Fixes: #235

Rename `Absolute.prototype.inZone` and `DateTime.prototype.inZone` to
`Absolute.prototype.inTimeZone` and `DateTime.prototype.inTimeZone`
respectively, since Temporal.TimeZone now exists.

Fixes: #235
@ryzokuken ryzokuken added this to the November Meeting milestone Nov 1, 2019
@ryzokuken ryzokuken requested review from littledan, pipobscure and maggiepint Nov 1, 2019
@ryzokuken ryzokuken self-assigned this Nov 1, 2019
@ryzokuken ryzokuken referenced this pull request Nov 1, 2019
@ljharb
ljharb approved these changes Nov 1, 2019
@ryzokuken

This comment has been minimized.

Copy link
Member Author

ryzokuken commented Nov 2, 2019

Thanks! Merging.

@ryzokuken ryzokuken merged commit a26e451 into tc39:main Nov 2, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.