Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin @babel/plugin-transform-for-of version #459

Closed
wants to merge 1 commit into from
Closed

Conversation

@ptomato
Copy link
Collaborator

ptomato commented Mar 21, 2020

This seems to be a regression with Babel 7.9.0 that wasn't yet caught
in any of their emergency releases today.

This seems to be a regression with Babel 7.9.0 that wasn't yet caught
in any of their emergency releases today.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #459 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          18       18           
  Lines        3720     3720           
  Branches      567      567           
=======================================
  Hits         3568     3568           
  Misses        147      147           
  Partials        5        5
Flag Coverage Δ
#test262 48.56% <ø> (ø) ⬆️
#tests 91.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 812bec5...87b64ff. Read the comment docs.

"rollup": "^1.23.1",
"rollup-plugin-babel": "^4.3.3",
"rollup-plugin-node-builtins": "^2.1.2",
"rollup-plugin-uglify": "^6.0.4"
},
"resolutions": {
"@babel/plugin-transform-for-of": "7.8.6"

This comment has been minimized.

Copy link
@ljharb

ljharb Mar 21, 2020

Member

i think just making this a dev dep would work, without the force resolutions thing?

This comment has been minimized.

Copy link
@ptomato

ptomato Mar 21, 2020

Author Collaborator

@babel/preset-env would pull in 7.9.0, so I'm not sure if npm would dedupe it. Anyway, hopefully this will shortly be moot.

This comment has been minimized.

Copy link
@ljharb

ljharb Mar 21, 2020

Member

ah, fair enough

@ptomato

This comment has been minimized.

Copy link
Collaborator Author

ptomato commented Mar 21, 2020

Not necessary anymore.

@ptomato ptomato closed this Mar 21, 2020
@ptomato ptomato deleted the ptomato:build-fix branch Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.