Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Editor feedback #107

Merged
merged 4 commits into from Jun 5, 2019

Conversation

Projects
None yet
4 participants
@guybedford
Copy link
Collaborator

commented Jun 5, 2019

This includes the feedback from @ljharb from #77 (comment), including:

  1. "rebasing" to the renaming of instantiate to link.
  2. Remove the now-unnecessary editors note from a previous iteration
  3. Include promise capability assertions.
  4. Separating out the steps promise resolutions into their own abstract functions referenced.

Will continue discussion on some of the other points continuing in the thread on #77.

@guybedford guybedford referenced this pull request Jun 5, 2019

Closed

Stage 3 reviews #77

4 of 5 tasks complete
@littledan
Copy link
Member

left a comment

LGTM. Will wait for @ljharb 's review before merging.

Show resolved Hide resolved spec.html Outdated

@guybedford guybedford force-pushed the guybedford:editor-feedback branch from 622edfb to fdf980c Jun 5, 2019

@ljharb

ljharb approved these changes Jun 5, 2019

@MylesBorins MylesBorins merged commit 5f0d551 into tc39:master Jun 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.