Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylize RoundingType values as internal values. Fixes #81 #91

Merged
merged 1 commit into from Jan 20, 2020
Merged

Conversation

@sffc
Copy link
Collaborator

sffc commented Jan 10, 2020

@spectranaut @ljharb Is this change correct?

@sffc sffc requested review from ljharb, Ms2ger, spectranaut and caiolima Jan 10, 2020
@spectranaut

This comment has been minimized.

Copy link

spectranaut commented Jan 10, 2020

Yes this change looks right to me. We never had a reason to use this notation before (at least, I couldn't find a case when reviewing 402 after @rkirsling cleaned up 262), but I think we should be consistent with 262 and use it here.

@Ms2ger
Ms2ger approved these changes Jan 10, 2020
@ljharb
ljharb approved these changes Jan 10, 2020
@sffc sffc merged commit 8ead539 into master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.