Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default method #35

Merged
merged 15 commits into from Nov 29, 2019
Merged

Rename default method #35

merged 15 commits into from Nov 29, 2019

Conversation

@ctavan
Copy link
Collaborator

ctavan commented Nov 25, 2019

Discussion in #3 yielded the following conclusions as of 2019-11-25:

  • We only want to support v4 UUIDs initially
  • Exporting them as uuid() might cause confusion should we ever want to support other algoritihms in the future.
  • Using "v4" in the name seems to cause more confusion than clarification since the whole "Version" terminology in the RFC is pretty confusing per se.
  • Using the term "random" to describe v4 UUIDs yielded generally positive feedback and other languages/libraries seem to use it as well.
  • There's general agreement that we should not support algorithms other than v4 random UUIDs for now.

We are still undecided whether we want to propose additional functionality around parsing UUIDs or outputting them in representations other than strings (e.g. bytes).

@rmg feel free to have a look as well!

@ctavan ctavan requested review from broofa, littledan, bcoe and bakkot Nov 25, 2019
Discussion in #3 yielded the following conclusions as of 2019-11-25:

- We only want to support v4 UUIDs initially
- Exporting them as uuid() might cause confusion should we ever want to
  support other algoritihms in the future.
- Using "v4" in the name seems to cause more confusion than
  clarification since the whole "Version" terminology in the RFC is
  pretty confusing per se.
- Using the term "random" to describe v4 UUIDs yielded generally
  positive feedback and other languages/libraries seem to use it as
  well.
- There's general agreement that we should not support algorithms other
  than v4 random UUIDs for now.
@ctavan ctavan force-pushed the rename-default-method branch from 0612c02 to abada13 Nov 25, 2019
Discussion in #3 showed that there is general agreement for only
supporting the v4 algorithm.

However, there are concerns that, if we design an API that promotes one
algorithm as the default, this assumption might not hold in the future.
In order to provide a more future-proof API we may therefore only
support certain algorithms, but will likely not treat any of the
supported algorithms in a speacial way.
@bakkot
bakkot approved these changes Nov 25, 2019
@ctavan ctavan requested a review from bakkot Nov 25, 2019
@rmg
rmg approved these changes Nov 25, 2019
@bcoe
bcoe approved these changes Nov 25, 2019
Copy link
Collaborator

bcoe left a comment

This is looking compelling to me; I think we should add a couple sections to the document based on the discussion in #3, otherwise this is looking good to me.

README.md Show resolved Hide resolved
ctavan added 3 commits Nov 26, 2019
@bcoe
bcoe approved these changes Nov 26, 2019
Copy link
Collaborator

bcoe left a comment

a couple notes, but this is looking good to me.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ctavan added 6 commits Nov 26, 2019
@ctavan ctavan requested a review from bcoe Nov 26, 2019
@bcoe
bcoe approved these changes Nov 27, 2019
@bcoe

This comment has been minimized.

Copy link
Collaborator

bcoe commented Nov 27, 2019

let's leave this open for a bit and give @broofa, @littledan, and a few other folks a chance to chime in.

@broofa
broofa approved these changes Nov 27, 2019
Copy link
Collaborator

broofa left a comment

A couple minor nits, but otherwise looks good!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ctavan and others added 3 commits Nov 28, 2019
Co-Authored-By: Robert Kieffer <robert@broofa.com>
Co-Authored-By: Robert Kieffer <robert@broofa.com>
@bcoe bcoe merged commit 4543b59 into master Nov 29, 2019
4 checks passed
4 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bcoe bcoe deleted the rename-default-method branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.