Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown checker #226

Draft
wants to merge 16 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@oyilmaztekin
Copy link
Contributor

commented Jul 1, 2019

#140

  • added markdown reader
  • parsed markdown to the AST
  • detected all tables
  • collected all link definitions
  • started to add tests

Discussions: #140 (comment)

ozer.yilmaztekin
added source code reader
added parser

detected all tables into the MD file

collected all link definitions

started to add tests
Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved package.json Outdated
ozer.yilmaztekin
downgraded version from 1 to 0
changed pacakge publication to private
@oguzzkilic

This comment has been minimized.

Copy link

commented Jul 2, 2019

Adding it in eslint + airbnb configuration can be good for code standard.

oyilmaztekin and others added some commits Jul 2, 2019

Update tablerow object dot notation
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
update private property
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Update Object dot notation
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Update test description
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Update test description
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Update dot notation in test
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Update dot notation
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Update destructuring assignment
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
ozer.yilmaztekin
reduced analyzeTable function
added missing newlines
const markdownStage3 = readMarkdown(stage3);
const parsedFile = parseToAST(markdownStage3);
const collectedLinkDefinitions = collectLinkDefinitions(parsedFile);
const tableStage1 = tableAnalyzer(parsedFile, collectedLinkDefinitions);

This comment has been minimized.

Copy link
@chicoxyzzy

chicoxyzzy Jul 2, 2019

Member

tableStage1 is not used anywhere. Also why stage 1?

This comment has been minimized.

Copy link
@oyilmaztekin

oyilmaztekin Jul 2, 2019

Author Contributor

Still developing...


module.exports = function generateTable(node, linkDefinitions) {
const table = node.children && detectTables(node);
const rows =

This comment has been minimized.

Copy link
@chicoxyzzy

chicoxyzzy Jul 2, 2019

Member

unused variable

This comment has been minimized.

Copy link
@oyilmaztekin

oyilmaztekin Jul 2, 2019

Author Contributor

This Pr does not represent the final code. I want to share with you how development is going on and get you involved.


module.exports = function traverseChildren(node, callBackLogic) {
node.forEach(n => {
callBackLogic();

This comment has been minimized.

Copy link
@chicoxyzzy

chicoxyzzy Jul 2, 2019

Member

callBackLogic is undefined in recursive calls

This comment has been minimized.

Copy link
@oyilmaztekin

oyilmaztekin Jul 2, 2019

Author Contributor

Development is still going on...

Oguz Kilic and others added some commits Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.