Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier not used in pre-commit hook #157

Closed
Regaddi opened this issue Jun 4, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@Regaddi
Copy link
Contributor

commented Jun 4, 2019

We're using stylelint to lint and autofix staged scss files.
I think we should do the same for javascript files and prettier. Prettier is already configured as part of the project.

@ljharb

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

eesh, i didn’t realize husky was being used. Autoinstalling git hooks is a huge security concern - husky in particular has accidentally installed git hooks in my company’s private internal repo. It’d be ideal to remove it entirely.

@Regaddi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

That's a good point. I'd suggest we adjust the CI instead and run the linting on Travis. So anyone working on this site is required to have everything set up locally properly.

@ljharb

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

yes, that’s the only way to actually ensure consistency anyways, since hooks can be bypassed :-)

Regaddi added a commit to Regaddi/tc39.github.io that referenced this issue Jun 4, 2019

@Regaddi Regaddi closed this Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.