Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #107 -add a tag list legend #121

Merged
merged 4 commits into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@codehag
Copy link
Collaborator

codehag commented Mar 9, 2019

This adds a details section for explaining the tags in the proposals

@codehag

This comment has been minimized.

Copy link
Collaborator Author

codehag commented Mar 9, 2019

@ljharb your thoughts would be appreciated !

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Mar 9, 2019

Is there a way to view this PR rendered?

@codehag

This comment has been minimized.

Copy link
Collaborator Author

codehag commented Mar 9, 2019

yes, via netlify: https://deploy-preview-121--tc39-beta.netlify.com/

you can find the link here:

Screenshot 2019-03-09 at 20 09 08

@ljharb

ljharb approved these changes Mar 9, 2019

Copy link
Member

ljharb left a comment

Awesome, the preview’s great! LGTM, only minor suggestions.

<ul class="featurelist__legend__tags">
<li>Last Presented:
<div class="featurelist__item__presented featurelist__item__tag">
<a href="./" title="Notes from most recent presentation">December 2018</a>

This comment has been minimized.

@ljharb

ljharb Mar 9, 2019

Member

I’d probably link these to # so they don’t navigate when clicked?

Show resolved Hide resolved _includes/proposals.html Outdated
<li>Specification Text:
<div class="featurelist__item__spec featurelist__item__tag">
<a href="./" title="Read the specification text">Specification</a>
</div>

This comment has been minimized.

@ljharb

ljharb Mar 9, 2019

Member
Suggested change
</div>
</div>
</li>
<li>Specification Text:
<div class="featurelist__item__spec featurelist__item__tag">
<a href="./" title="Read the specification text">Specification</a>

This comment has been minimized.

@ljharb

ljharb Mar 9, 2019

Member
Suggested change
<a href="./" title="Read the specification text">Specification</a>
<a href="./" title="Read the specification text">Specification</a>

ljharb and others added some commits Mar 9, 2019

Update _includes/proposals.html
Co-Authored-By: codehag <yulia.startsev@gmail.com>

@codehag codehag merged commit 7595e79 into master Mar 9, 2019

1 check passed

deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.