Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for numeric separator #1051

Closed
rwaldron opened this issue May 24, 2017 · 4 comments

Comments

@rwaldron
Copy link
Contributor

commented May 24, 2017

Once the spec grammar is written, reference: https://github.com/samuelgoto/proposal-numeric-separator

@rwaldron rwaldron self-assigned this May 24, 2017

@leobalter

This comment has been minimized.

Copy link
Member

commented May 24, 2017

@littledan

This comment has been minimized.

Copy link
Member

commented Jun 6, 2017

Proposals can advance multiple stages in a single meeting, and this one is relatively simple.

I came across this bug report when I was about to file another one, about tests for class fields. I thought it'd make sense to keep this in bugs so that we can make sure not to duplicate each other's work. Tests can hang out in PRs against test262 for a while and be useful for people who are collaborating on a proposal.

What if, rather than not filing bug reports, we made a label for what stage things are at, and you can filter things out by label? (I don't have permissions to make labels, so I can't do this organization myself, but if you give me permission...).

@leobalter

This comment has been minimized.

Copy link
Member

commented Jun 6, 2017

@bterlson

This comment has been minimized.

Copy link
Member

commented Jun 6, 2017

@leobalter I've added @littledan to @tc39/test262

@littledan littledan added the future label Jun 6, 2017

rwaldron added a commit to rwaldron/test262 that referenced this issue Aug 14, 2017
rwaldron added a commit to rwaldron/test262 that referenced this issue Aug 14, 2017
rwaldron added a commit to rwaldron/test262 that referenced this issue Aug 14, 2017
rwaldron added a commit to rwaldron/test262 that referenced this issue Aug 14, 2017
rwaldron added a commit to rwaldron/test262 that referenced this issue Aug 15, 2017
rwaldron added a commit to rwaldron/test262 that referenced this issue Aug 15, 2017

@leobalter leobalter closed this in 844e317 Aug 21, 2017

leobalter added a commit that referenced this issue Aug 21, 2017
Merge pull request #1176 from rwaldron/1051
Tests for NumericSeparatorLiteral. Closes gh-1051
leobalter added a commit that referenced this issue Aug 21, 2017
leobalter added a commit that referenced this issue Aug 21, 2017
leobalter added a commit that referenced this issue Aug 21, 2017

@leobalter leobalter reopened this Aug 21, 2017

rwaldron added a commit that referenced this issue Sep 19, 2017
rwaldron added a commit to rwaldron/test262 that referenced this issue Sep 25, 2017
rwaldron added a commit to rwaldron/test262 that referenced this issue Sep 28, 2017
rwaldron added a commit to rwaldron/test262 that referenced this issue Nov 28, 2017
leobalter added a commit that referenced this issue Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.