New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for String.prototype.matchAll #1500

Merged
merged 3 commits into from Apr 11, 2018

Conversation

Projects
None yet
4 participants
@ljharb
Copy link
Member

ljharb commented Mar 20, 2018

String.prototype.matchAll is at stage 3.

Here's the tests for it; with help from @peterwmwong / ljharb#1.

Please do not merge this yet; there's still a few unresolved issues on the proposal repo and I'd rather update the PR in-place if there ends up being changes :-)

ljharb and others added some commits Jan 25, 2018

String.prototype.matchAll: add tests for stage 3
`String.prototype.matchAll`: Add basic tests.
String.prototype.matchAll: add tests for stage 3
`RegExp.prototype[Symbol.matchAll]`: Add basic tests.
Fleshed out tests for Symbol.matchAll, String.p.matchAll, RegExp.p[@@…
…matchAll], and %RegExpStringIteratorPrototype%

Tests were updated and assuming tc39/proposal-string-matchall#33 will be merged.

@ljharb ljharb requested review from rwaldron and leobalter Mar 20, 2018

@ljharb ljharb force-pushed the ljharb:matchall branch from 965590f to c6d6822 Mar 21, 2018

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Apr 1, 2018

@rwaldron

This comment has been minimized.

Copy link
Contributor

rwaldron commented Apr 3, 2018

@ljharb

Please do not merge this yet;

Ready to go then?

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Apr 4, 2018

Yes, i think so! There’s still tc39/proposal-string-matchall#34, but I’ll file any update PRs here if there’s changes as a result.

@ljharb ljharb force-pushed the ljharb:matchall branch from c6d6822 to f1e45d9 Apr 10, 2018

@rwaldron
Copy link
Contributor

rwaldron left a comment

Thorough!

# String.prototype.matchAll
# https://github.com/tc39/proposal-string-matchall
String.prototype.matchAll
Symbol.matchAll

This comment has been minimized.

@rwaldron

rwaldron Apr 11, 2018

Contributor

👍

@rwaldron rwaldron merged commit 3e4f58d into tc39:master Apr 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ljharb ljharb deleted the ljharb:matchall branch Apr 11, 2018

@ljharb ljharb referenced this pull request Apr 12, 2018

Open

Path to Stage 4! #21

15 of 27 tasks complete
This property has the attributes { [[Writable]]: false, [[Enumerable]]:
false, [[Configurable]]: false }.
includes: [propertyHelper.js]
features: [Symbol.match]

This comment has been minimized.

@gsathya

gsathya Jun 6, 2018

Member

This should be Symbol.matchAll

This comment has been minimized.

@peterwmwong

peterwmwong Jun 6, 2018

Contributor

@gsathya Thanks, this is already being corrected with this PR (that is updating to the latest spec changes): https://github.com/tc39/test262/pull/1587/files#diff-dcc8c9cf15ec70a98b42af64c99e751d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment