Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for String.prototype.matchAll changes #2389

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@ljharb
Copy link
Member

commented Oct 3, 2019

@ljharb ljharb requested a review from leobalter Oct 3, 2019
@ljharb ljharb force-pushed the ljharb:matchall_tests branch from 4f3d1b1 to 72173f4 Oct 3, 2019
Copy link
Member

left a comment

Thanks @ljharb — that was quick :) The patch LGTM.

Are there any existing tests that need changing?

@ljharb

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

Not that I could see.

@leobalter leobalter merged commit f3e950e into tc39:master Oct 3, 2019
2 of 8 checks passed
2 of 8 checks passed
ci/circleci: ChakraCore: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: JSC: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: SpiderMonkey: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: V8 --harmony: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: V8: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: XS: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: Project lint and generation unit tests on Python 3 Your tests passed on CircleCI!
Details
ci/circleci: Project lint, generation tests and build Your tests passed on CircleCI!
Details
@ljharb ljharb deleted the ljharb:matchall_tests branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.