Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[matchAll] pass a global regex #2399

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@ljharb
Copy link
Member

commented Oct 9, 2019

 - also, expect the right kind of error in `flags-undefined-throws.js`

Fixes #2398
@ljharb ljharb force-pushed the ljharb:matchall_fixes branch from 26445a2 to b87c5f8 Oct 9, 2019
@syg
syg approved these changes Oct 9, 2019
Copy link
Contributor

left a comment

I, too, approve this message.

@ljharb ljharb requested a review from leobalter Oct 9, 2019
@leobalter leobalter merged commit 59d1af9 into tc39:master Oct 9, 2019
2 of 8 checks passed
2 of 8 checks passed
ci/circleci: ChakraCore: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: JSC: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: SpiderMonkey: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: V8 --harmony: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: V8: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: XS: New or modified tests execution Your tests failed on CircleCI
Details
ci/circleci: Project lint and generation unit tests on Python 3 Your tests passed on CircleCI!
Details
ci/circleci: Project lint, generation tests and build Your tests passed on CircleCI!
Details
@ljharb ljharb deleted the ljharb:matchall_fixes branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.