Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Promise/prototype/finally/rejected-observable-then-calls-argument #2495

Merged
merged 1 commit into from Feb 13, 2020

Conversation

@devsnek
Copy link
Member

devsnek commented Feb 8, 2020

No description provided.

@ljharb
ljharb approved these changes Feb 8, 2020
Copy link
Member

ljharb left a comment

we should probably also assert on the name and length of the reject function

@devsnek

This comment has been minimized.

Copy link
Member Author

devsnek commented Feb 13, 2020

@ljharb its not part of the test in this case.

@rwaldron rwaldron merged commit 900855b into tc39:master Feb 13, 2020
9 checks passed
9 checks passed
ci/circleci: ChakraCore: New or modified tests execution Your tests passed on CircleCI!
Details
ci/circleci: JSC: New or modified tests execution Your tests passed on CircleCI!
Details
ci/circleci: Project lint and generation unit tests on Python 3 Your tests passed on CircleCI!
Details
ci/circleci: Project lint, generation tests and build Your tests passed on CircleCI!
Details
ci/circleci: SpiderMonkey: New or modified tests execution Your tests passed on CircleCI!
Details
ci/circleci: V8 --harmony: New or modified tests execution Your tests passed on CircleCI!
Details
ci/circleci: V8: New or modified tests execution Your tests passed on CircleCI!
Details
ci/circleci: XS: New or modified tests execution Your tests passed on CircleCI!
Details
ci/circleci: engine262: New or modified tests execution Your tests passed on CircleCI!
Details
@devsnek devsnek deleted the devsnek:patch-1 branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.