Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for legacy RegExp features #2650

Merged

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jun 7, 2020

This adds tests for the legacy RegExp features proposal:

  • Property descriptors of legacy static accessors
  • Cross‑realm and subclass calls of legacy static accessors
  • Cross‑realm and subclass calls of RegExp.prototype.compile

Resolves #2371
Resolves tc39/proposal-regexp-legacy-features#15

Copy link
Contributor

@rwaldron rwaldron left a comment

I suspect we'll need a new feature tag for this. Can you add legacy-regexp to features.txt, and then include it in all of these tests? Thanks!

@leobalter leobalter changed the base branch from master to main Jul 15, 2020
@leobalter
Copy link
Member

leobalter commented Jul 15, 2020

FYI, I updated the base branch from master to main.

@ExE-Boss ExE-Boss force-pushed the proposal-regacy-regexp-features/add-basic-tests branch from 77699f6 to 91f5191 Compare Jul 23, 2020
@rwaldron
Copy link
Contributor

rwaldron commented Sep 10, 2020

@syg heads up for new failures in V8

@rwaldron rwaldron dismissed leobalter’s stale review Sep 10, 2020

Everything was fixed

@rwaldron rwaldron merged commit 9c754bc into tc39:main Sep 10, 2020
2 of 10 checks passed
@ExE-Boss ExE-Boss deleted the proposal-regacy-regexp-features/add-basic-tests branch Sep 11, 2020
features.txt Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for test262 Missing coverage for Legacy RegExp features
4 participants