New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `global` tests. #765

Merged
merged 1 commit into from Sep 28, 2016

Conversation

Projects
None yet
3 participants
@ljharb
Copy link
Member

ljharb commented Sep 28, 2016

@tcare

This comment has been minimized.

Copy link
Member

tcare commented Sep 28, 2016

Looks good

@tcare tcare merged commit be16caa into tc39:master Sep 28, 2016

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Sep 28, 2016

@tcare this isn't stage 3 yet, but hopefully will be today or tomorrow. Please don't revert just yet; but please be prepared to do so after tomorrow if some new issue is found.

@ljharb ljharb deleted the ljharb:global_global branch Sep 28, 2016

@leobalter

This comment has been minimized.

Copy link
Member

leobalter commented Sep 28, 2016

oops, it's not stage 3 yet, but it might reach it tomorrow. Otherwise we'll need to revert it (again).

@leobalter

This comment has been minimized.

Copy link
Member

leobalter commented Sep 28, 2016

Ok, I've answered before getting the comment from @ljharb, basically the same as I told.

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Sep 28, 2016

OK, this is now stage 3, so this is good to remain in master 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment