Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance absolute version dependency to accept "1.0.0" #39

Merged
merged 1 commit into from Jun 9, 2017

Conversation

@chr1shaefn3r
Copy link
Contributor

@chr1shaefn3r chr1shaefn3r commented Jun 2, 2017

Instead of relying only on a "=" prefix, this enhanced version works by
making sure all "non-absolute" version rangs are not used, e.g. "~", "^".

From the semver Backus-Naur grammar
(https://www.npmjs.com/package/semver) is only missing that a "x" and
"X" can be used instead of "*".

This change is motivated by the experience over the last several days that a workflow which tries to make sure a "=" prefixed version ends up in the package.json and yarn.lock is to tedious.
Main reason is that one needs to manually look up the latest version to run e.g.:
yarn add winston@=2.3.1
With this pull request you just need to run:
yarn add -E winston
No need to manually check the version :)

Instead of relying only on a "=" prefix, this enhanced version works by
making sure all "non-absolute" version rangs are not used, e.g. "~", "^".

From the semver Backus-Naur grammar
(https://www.npmjs.com/package/semver) is only missing that a "x" and
"X" can be used instead of "*".
@tclindner tclindner added this to the v2.5.0 milestone Jun 9, 2017
@tclindner
Copy link
Owner

@tclindner tclindner commented Jun 9, 2017

Nice work, @chr1shaefn3r! I really like this improvement. I'll get a new version packaged up this weekend.

@tclindner tclindner merged commit 33656d0 into tclindner:master Jun 9, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tclindner
Copy link
Owner

@tclindner tclindner commented Jun 11, 2017

Hey @chr1shaefn3r v2.5.0 has been published! The documentation has been updated too. Let me know if you see any issues.

prefer-absolute-version-dependencies
prefer-absolute-version-devDependencies

@chr1shaefn3r
Copy link
Contributor Author

@chr1shaefn3r chr1shaefn3r commented Jun 12, 2017

Thank you very much on prefer-absolute-version-devDependencies is a small copy&paste error: the headline still says "dependencies" instead of "devDependencies". Other than it looks good :)

@tclindner
Copy link
Owner

@tclindner tclindner commented Jun 17, 2017

Fixed! Good eye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants