Skip to content

chore: Set permissions for GitHub actions#13

Closed
nathannaveen wants to merge 1 commit intotcltk:mainfrom
turrisxyz:setup-permissions
Closed

chore: Set permissions for GitHub actions#13
nathannaveen wants to merge 1 commit intotcltk:mainfrom
turrisxyz:setup-permissions

Conversation

@nathannaveen
Copy link

 Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nijtmans nijtmans self-assigned this May 22, 2022
andreas-kupries pushed a commit to tcltk/tk that referenced this pull request May 23, 2022
andreas-kupries pushed a commit that referenced this pull request May 23, 2022
andreas-kupries pushed a commit to tcltk/sampleextension that referenced this pull request May 24, 2022
andreas-kupries pushed a commit to tcltk/thread that referenced this pull request May 24, 2022
@nijtmans nijtmans closed this May 25, 2022
@nijtmans
Copy link
Member

Merged to all branches. Thanks!

@nijtmans nijtmans added the accepted It's sorted (since this is a mirror, we can't directly accept the PR) label May 25, 2022
@nathannaveen
Copy link
Author

Merged to all branches. Thanks!

Sorry, I don't understand what you mean by "Merged to all branches" because this PR is closed.

@nijtmans
Copy link
Member

Sorry, I don't understand what you mean by "Merged to all branches" because this PR is closed.

Tcl/Tk is hosted in a fossil repository here. This GIT repository is just a mirror, the real work is done in fossil. Therefore, it would be better if you raised tickets in fossil, but I understand that not everyone is willing to take time to get to know fossil. So, - once in a while - I look here too.

sebres pushed a commit to sebres/tcl that referenced this pull request May 31, 2022
tcl-mirror pushed a commit to tcl-mirror/tdbc that referenced this pull request Jun 28, 2022
tcl-mirror pushed a commit to tcl-mirror/sampleextension that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted It's sorted (since this is a mirror, we can't directly accept the PR)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants