New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding newlines to output by default #15

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@itskingori
Copy link

itskingori commented Sep 23, 2017

When newlines are hardcoded in the library, all user's of this library are forced into that ui-design choice without a way to modify that behaviour. This way, user's can opt to add newlines as they wish ... in their own tools.

For example, in the example below ... I would like not two have two empty lines after "Failed to validate". And even if I did, I'd prefer to have to add them myself for flexibility.

Before:

$ cli-tool-that-does-something
What is your token uuid?
Enter a value: afdsf
Failed to validate input string: afdsf


Enter a value: 2343242

After:

$ cli-tool-that-does-something
What is your token uuid?
Enter a value: afdsf
Failed to validate input string: afdsf
Enter a value: 2343242

I took the liberty to remove other newlines.

Avoid adding newlines to output by default
When newlines are hardcoded in the library, all user's of this library
are forced into that ui-design choice without a way to modify that
behaviour. This way, user's can opt to add newlines as they wish ...
in their own tools.

@itskingori itskingori force-pushed the itskingori:remove_newlines_from_output branch from 3985332 to 54ca812 Sep 23, 2017

@thedillonb

This comment has been minimized.

Copy link

thedillonb commented Apr 19, 2018

@tcnksm any chance you could provide some feedback on this? The newlines are definitely odd and would be welcome if they were removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment