Remove ability to block oneself #23

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants

Hi,

Great gem, saved me a lot of code! I've forked and made two bug fixes and one improvement suggestion. Please review, and feel free to pull one or more of them:

  1. Latest factory_girl version is not compatible with ruby 1.8, so I locked the gem to a version that works with 1.8 and 1.9.
  2. Latest shoulda has deprecated & removed should_change, which your tests use. Locked the gem to an older version that still has this method.
  3. Since an object cannot follow oneself, it makes no sense to be able to block oneself. I removed the ability and added a test to verify a followable cannot block oneself.

Regards, Ryan

rtdp commented Jul 4, 2012

Is this not being maintained anymore ?

From above commits, this fix is imp for tests to run now - https://github.com/ryandrake08/acts_as_follower/commit/9b883fdbe2f683ab89a90e16b57bf4e1631dc43e

Please consider getting it in. thanks !

Looks like this was finally fixed with #59
Closing this ancient pull request.

ryandrake08 closed this May 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment