New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data returned from website didn't match expected format #70

Open
nh2amine opened this Issue Jan 24, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@nh2amine

nh2amine commented Jan 24, 2017

The app seems unable to retrieve any strip from the xkcd site since several days.

@hamlet

This comment has been minimized.

hamlet commented Jan 27, 2017

Please, do something! :-)

@Sophira

This comment has been minimized.

Sophira commented May 19, 2017

I'm not the app's dev, but looking at what the app is doing, it seems like this should be a really simple fix; the app seems to be requesting http://xkcd.com/info.0.json , and failing because the website redirects it to the HTTPS version, https://xkcd.com/info.0.json . It does not follow the redirect.

The easy fix would be to correct the URL in getFinalComicUrl in xkcdViewer/src/main/java/net/bytten/xkcdviewer/XkcdComicProvider.java. I'll open a pull request for this but since I'm not the dev, I can't promise that it'll get in, and I don't have the build environment or the energy to maintain a fork of this.

Sophira added a commit to Sophira/XkcdViewer that referenced this issue May 19, 2017

Update xkcdViewer provider to use HTTPS URLs
xkcd.com changed to using HTTPS some time ago; the change causes
XkcdViewer to fail with "Data returned from website didn't match
expected format" as the 301 redirect is attempted to be parsed as JSON,
which obviously fails.

While this isn't a complete fix, it should hopefully fix the app enough
for it to work again.

Fixes tcoxon#70.

@Sophira Sophira referenced a pull request that will close this issue May 19, 2017

Open

Update xkcdViewer provider to use HTTPS URLs #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment