Merge pull request #268 from danielbom/fix/force-string-never-works

fix: #263 forceString invalid implementation
node-cache · Nov 5, 2021 · 1e5c75e · 1e5c75e
2 parents 3d6ef83 + 18f8466
commit 1e5c75e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/_src/lib/node_cache.coffee b/_src/lib/node_cache.coffee
@@ -164,7 +164,7 @@ module.exports = class NodeCache extends EventEmitter
 			throw _err
 
 		# force the data to string
-		if @options.forceString and not typeof value is "string"
+		if @options.forceString and typeof value isnt "string"
 			value = JSON.stringify( value )
 
 		# set default ttl if not passed

diff --git a/_src/test/mocha_test.coffee b/_src/test/mocha_test.coffee
@@ -1303,5 +1303,28 @@ describe "`#{pkg.name}@#{pkg.version}` on `node@#{process.version}`", () ->
 			return
 		)
 
+		describe("#263 - forceString never works", () ->
+			cache = null
+			before(() ->
+				cache = new nodeCache({
+					forceString: true
+				})
+				return
+			)
+
+			it("set the value `null` - this should transform into a string", () -> 
+				cache.set "test", null
+				should(cache.get("test")).eql("null")
+				return
+			)
+
+			it("set the value `{ hello: 'World' }` - this should transform into a string", () -> 
+				cache.set "test", { hello: 'World' }
+				should(cache.get("test")).eql("{\"hello\":\"World\"}")
+				return
+			)
+			return
+		)
+
 		return
 	return