tests/lexical.at: fix regexp for backslash quoting tests for newer 'sed' #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with sed-4.3 version, the tests would fail because sed apparently no longer supports using [:group:]*. Instead, [[:group:]]* has to be used.
|
Had anybody chance to look into this, please? :) |
|
On Feb 23, 8:04am, notifications@github.com (deekej) wrote:
-- Subject: Re: [tcsh-org/tcsh] tests/lexical.at: fix regexp for backslash qu
| Had anybody chance to look into this, please? :)
Yes, Looks good and I will commit it.
christos
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the Fedora 26 Mass Rebuild, it was discovered build of tcsh would fail in the
make checkphase.Further investigation showed me that sed was failing with this error message:
Apparently, starting with version 4.3 (or newer version used in Fedora),
sedno longer supports using simple[:group:]*. Instead, the[[:group:]]*has to be used.