Couple of fixes from Gentoo #4

Merged
merged 3 commits into from Aug 12, 2012

Conversation

Projects
None yet
2 participants
@Flameeyes
Contributor

Flameeyes commented Aug 10, 2012

Hello,

I'm packaging jmx2munin in Gentoo and these are a couple of fixes I think could be useful.

I'll probably send you something more, the big issue for us is that we have a very different way to handle Java packages so we're basically working a number of things around.

Flameeyes added some commits Aug 10, 2012

jmx2munin.sh: don't search for the jar file among plugins.
This makes it behave more like the actual JMX jar shipping with Munin.
jmx2munin: give a default value for config.
This allows for users to use the plugin as a wildcard one, which is
more in line with Munin itself.
@tcurdt

This comment has been minimized.

Show comment Hide comment
@tcurdt

tcurdt Aug 12, 2012

Owner

Thanks for the fixes.

What packaging issue do you see? jmx2munin does not even expose dependencies. It cannot get much easier than this :)

Owner

tcurdt commented Aug 12, 2012

Thanks for the fixes.

What packaging issue do you see? jmx2munin does not even expose dependencies. It cannot get much easier than this :)

tcurdt added a commit that referenced this pull request Aug 12, 2012

Merge pull request #4 from gentoo/master
Couple of fixes from Gentoo

@tcurdt tcurdt merged commit 6a239b3 into tcurdt:master Aug 12, 2012

@Flameeyes

This comment has been minimized.

Show comment Hide comment
@Flameeyes

Flameeyes Aug 12, 2012

Contributor

Well, we have a policy that disallows bundling of libraries, which in this case includes jcommander — which is not a problem, as I wrote a package for jcommander that works just fine, but it requires it to be loaded beforehand.

I guess the main issue is that Maven and Gentoo don't play nice together — like Rubygems didn't up to one or two years ago. But the package is now available, users can just emerge jmx2munin and then set it up :)

Contributor

Flameeyes commented Aug 12, 2012

Well, we have a policy that disallows bundling of libraries, which in this case includes jcommander — which is not a problem, as I wrote a package for jcommander that works just fine, but it requires it to be loaded beforehand.

I guess the main issue is that Maven and Gentoo don't play nice together — like Rubygems didn't up to one or two years ago. But the package is now available, users can just emerge jmx2munin and then set it up :)

@tcurdt

This comment has been minimized.

Show comment Hide comment
@tcurdt

tcurdt Aug 12, 2012

Owner

Pretty cool that it's available :)

That said - the non-bundling policy is a bit odd. It certainly might make sense for bigger projects like Tomcat and friends, but there are good reasons why some projects bundle (or even even shade) the jars. It's like not allowing statically linked binaries. Anyway - probably not worth discussing policies here. Just saying.

Owner

tcurdt commented Aug 12, 2012

Pretty cool that it's available :)

That said - the non-bundling policy is a bit odd. It certainly might make sense for bigger projects like Tomcat and friends, but there are good reasons why some projects bundle (or even even shade) the jars. It's like not allowing statically linked binaries. Anyway - probably not worth discussing policies here. Just saying.

@Flameeyes

This comment has been minimized.

Show comment Hide comment
@Flameeyes

Flameeyes Aug 12, 2012

Contributor

And indeed we don't allow statically linked binaries if not for special cases (like busybox), at least not by default (we do have a way to select static building for any of the packages there).

But in general it's not much of a problem, just makes it a bit quirkier, but in this case it's really just a matter of a couple of changes and everything works fine, so, cheers :)

Contributor

Flameeyes commented Aug 12, 2012

And indeed we don't allow statically linked binaries if not for special cases (like busybox), at least not by default (we do have a way to select static building for any of the packages there).

But in general it's not much of a problem, just makes it a bit quirkier, but in this case it's really just a matter of a couple of changes and everything works fine, so, cheers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment