From be621af9716fe435c813e9af85da4c8b169098ad Mon Sep 17 00:00:00 2001 From: tdakkota Date: Sun, 11 Oct 2020 20:49:57 +0300 Subject: [PATCH] fix: simplify some expressions in glob matcher --- sql/query/glob/like.go | 4 ++-- sql/query/glob/like_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sql/query/glob/like.go b/sql/query/glob/like.go index e1d1bc326..aefcb6fe3 100644 --- a/sql/query/glob/like.go +++ b/sql/query/glob/like.go @@ -81,7 +81,7 @@ func MatchLike(pattern, s string) bool { // 3. p is an unescaped escape character, or // 4. p is to be handled as an ordinary character // - if p == matchAll && !prevEscape && p != matchEsc { + if p == matchAll && !prevEscape { // Case 1. var c byte @@ -116,7 +116,7 @@ func MatchLike(pattern, s string) bool { s = skipRune(s) } return false - } else if p == matchOne && !prevEscape && p != matchEsc { + } else if p == matchOne && !prevEscape { // Case 2. if len(s) == 0 { return false diff --git a/sql/query/glob/like_test.go b/sql/query/glob/like_test.go index ecc83f7c5..31ea3b4ca 100644 --- a/sql/query/glob/like_test.go +++ b/sql/query/glob/like_test.go @@ -37,7 +37,7 @@ func TestMatchLike(t *testing.T) { // Exact {"abc", "abc", true}, - {"aBc", "AbC", true}, + {"aBc", "AbC", false}, {"abc", "def", false}, // Prefix