Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parmap API to remove DeprecationWarnings #54

Merged
merged 1 commit into from Nov 18, 2017

Conversation

@zeehio
Copy link
Contributor

@zeehio zeehio commented Nov 10, 2017

Hi,

parmap 1.5.0 introduced support for passing keyword arguments to mapped functions. The drawback of this feature is that a consistent naming of parmap arguments is needed in order to prevent conflicts
between parmap arguments and user-defined arguments. The new parmap convention is to prefix all its arguments with "pm_" (for parmap) as documented http://parmap.readthedocs.io/en/latest/

This commit updates the DeepLearningImplementations parmap calls to use the new API, removing the deprecation warnings that appear with parmap==1.5.1 (the parmap version used).

https://github.com/zeehio/parmap/blob/e0bc5969ab13562ec9ea2d8131f1cd9ecb8448a7/ChangeLog#L11

Feel free to merge if you see fit 馃憤

Sergio (parmap author)

parmap 1.5.0 introduced support for passing keyword arguments to
mapped functions. The drawback of this feature is that a consistent
naming of parmap arguments is needed in order to prevent conflicts
between parmap arguments and user-defined arguments. The new parmap
convention is to prefix all its arguments with "pm_" (for parmap)
as documented http://parmap.readthedocs.io/en/latest/

This commit updates the DeepLearningImplementations parmap calls to
use the new API, removing the deprecation warnings that appear with
parmap==1.5.1 (the parmap version used).

https://github.com/zeehio/parmap/blob/e0bc5969ab13562ec9ea2d8131f1cd9ecb8448a7/ChangeLog#L11
@tdeboissiere tdeboissiere merged commit 0fa5f83 into tdeboissiere:master Nov 18, 2017
@tdeboissiere
Copy link
Owner

@tdeboissiere tdeboissiere commented Nov 18, 2017

Sounds good, merging

@zeehio zeehio deleted the zeehio:update_parmap_api branch Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants