Fix issues with URI resolution and fragment walking #22

Merged
merged 3 commits into from Dec 25, 2012

Conversation

Projects
None yet
2 participants
Collaborator

awwright commented Dec 22, 2012

Three of the imported tests still technically fail, but overall I'm confident this is now 100% compliant with JSON Schema v3 draft (to the extent that is technically possible when dealing with native ECMAScript objects).

Last thing to clean up is the validate() function should return a ValidationResult, and it needs tests and examples. I like the new README. I'm writing up an article on how to use this for doing HTTP APIs with multiple API versions/interfaces, using the profile parameter of the application/json media type.

awwright added some commits Dec 21, 2012

@awwright awwright Fix numerous problems with URI resolution and recursion 9339c18
@awwright awwright Cleanup specification of base
It's what URIs in that schema will be resolved against, not what to resolve the schema's own id against.
ea3c202
Owner

tdegrunt commented Dec 23, 2012

Could you re-merge with my master?

Collaborator

awwright commented Dec 24, 2012

I would have merged myself, but I haven't had access to my development utilities.

Did you try, but it created conflicts?

@awwright awwright Merge branch 'master' of git://github.com/tdegrunt/jsonschema
Conflicts:
	lib/attribute.js
	lib/helpers.js
	lib/validator.js
882f43b
Collaborator

awwright commented Dec 25, 2012

I meant to say: Of course there was going to be conflicts!

@tdegrunt tdegrunt added a commit that referenced this pull request Dec 25, 2012

@tdegrunt tdegrunt Merge pull request #22 from Acubed/master
Fix issues with URI resolution and fragment walking
4b09a93

@tdegrunt tdegrunt merged commit 4b09a93 into tdegrunt:master Dec 25, 2012

1 check failed

default The Travis build failed
Details
Owner

tdegrunt commented Dec 25, 2012

Thank you and, merry christmas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment