Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

query string #3

Closed
5at opened this Issue Oct 8, 2010 · 3 comments

Comments

Projects
None yet
2 participants

5at commented Oct 8, 2010

using a query string with a GET /db/col isnt working.
Debugging the code it appears that in rest.js code uses req.params to extract the parameters passed within the url's query component (the bit after the "?" of a url).
Shouldnt it be using req.query object instead to get to any of the parameters of the url's query component? (kinda confusing since "query" is used as a parameter name within the url's query :) )

This is for both req.params.query and req.params.option lines.
i.e. They should be req.query.query and req.query.option respectively.

Also since they are strings should they not also be evaled or json.evaled before being passed to find() ?

Owner

tdegrunt commented Oct 8, 2010

You're absolutely right, thank you!
This is something that changed between 0.5 and 0.6 and I missed it.

So, just committed the change to look at the req.query.query's query query and this should fix it ;)

Owner

tdegrunt commented Oct 11, 2010

Shouldn't have closed this too quickly, it's your ticket. Do you think it's sufficiently resolved?

Owner

tdegrunt commented Dec 20, 2010

Closing it now ...

@alopezo alopezo added a commit to termMed/mongodb-rest that referenced this issue Feb 18, 2014

@alopezo alopezo GET Concepts test #3 d9de177

@alopezo alopezo added a commit to termMed/mongodb-rest that referenced this issue Feb 18, 2014

@alopezo alopezo adding GET descriptions #3 21df338

@alopezo alopezo added a commit to termMed/mongodb-rest that referenced this issue Feb 18, 2014

@alopezo alopezo adding GET relationships #3 a1c6013

@alopezo alopezo added a commit to termMed/mongodb-rest that referenced this issue Feb 18, 2014

@alopezo alopezo adding GET search startswith #3 90189e9

@alopezo alopezo added a commit to termMed/mongodb-rest that referenced this issue Feb 20, 2014

@alopezo alopezo adding parents method #3 b8ed83d

@alopezo alopezo added a commit to termMed/mongodb-rest that referenced this issue Feb 27, 2014

@alopezo alopezo adding stemming #3 3277185

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment