HTML: keep empty title and lang attributes, fixes #331

tdewolff · Sep 23, 2020 · e740908 · e740908
1 parent 24d4dfc
commit e740908
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/html/html.go b/html/html.go
@@ -381,9 +381,7 @@ func (o *Minifier) Minify(m *minify.M, w io.Writer, r io.Reader, _ map[string]st
 						if len(val) == 0 && (attr.Hash == Class ||
 							attr.Hash == Dir ||
 							attr.Hash == Id ||
-							attr.Hash == Lang ||
 							attr.Hash == Name ||
-							attr.Hash == Title ||
 							attr.Hash == Action && t.Hash == Form) {
 							continue // omit empty attribute values
 						}

diff --git a/html/html_test.go b/html/html_test.go
@@ -146,6 +146,7 @@ func TestHTML(t *testing.T) {
 		{`<script><!--<`, `<script><!--<`},
 
 		// bugs
+		{`<input title=""><input lang="">`, `<input title><input lang>`},                                         // #331
 		{`<amp-analytics type=adobeanalytics_nativeConfig>`, `<amp-analytics type=adobeanalytics_nativeConfig>`}, // #270
 		{`<p>text</p><br>text`, `<p>text</p><br>text`},                                                           // #122
 		{`text <img> text`, `text <img> text`},                                                                   // #89