Skip to content

Conversation

sergey-s-betke
Copy link
Contributor

@sergey-s-betke sergey-s-betke commented Aug 14, 2021

@sergey-s-betke
Copy link
Contributor Author

@svanteschubert, please, merge this pull request... Thank You!

@svanteschubert
Copy link
Contributor

@svanteschubert, please, merge this pull request... Thank You!

I just talked to Michael Stahl (aka mistmist), he will take a look upon it.
The ODF validator is his "kingdom" and I am still in the middle of improving code-generation for ODFDOM using the MultiSchemaValidator...
But thanks for the patch and for the reminder!
Svante

Copy link
Contributor

@mistmist mistmist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay this looks mostly acceptable, except for the actual exit code being used - a simple thing to fix...

this requires adapting LO's test code which currently ignores stderr but https://gerrit.libreoffice.org/c/core/+/120943 should do it.

@sergey-s-betke
Copy link
Contributor Author

sergey-s-betke commented Aug 25, 2021

i think we should use a different exit value for "there were technical problems" and "validator reported invalid XML".

since "1" is already used for the first case, please use any other number for this.

I change exit code from 1 to 2:

Copy link
Contributor

@mistmist mistmist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mistmist mistmist merged commit fffacc0 into tdf:master Aug 26, 2021
@sergey-s-betke
Copy link
Contributor Author

thanks!

Welcome! 😁😁😁

@sergey-s-betke sergey-s-betke deleted the sergey-s-betke/issue120 branch August 27, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write validator errors to System.err ODFValidator & Exit Code
3 participants