-
Notifications
You must be signed in to change notification settings - Fork 53
Write validator errors to System.err #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@svanteschubert, please, merge this pull request... Thank You! |
I just talked to Michael Stahl (aka mistmist), he will take a look upon it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay this looks mostly acceptable, except for the actual exit code being used - a simple thing to fix...
this requires adapting LO's test code which currently ignores stderr but https://gerrit.libreoffice.org/c/core/+/120943 should do it.
I change exit code from 1 to 2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Welcome! 😁😁😁 |
Uh oh!
There was an error while loading. Please reload this page.