Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate input username #39

Closed
wants to merge 1 commit into from
Closed

Validate input username #39

wants to merge 1 commit into from

Conversation

arecker
Copy link

@arecker arecker commented Nov 27, 2014

Greetings,

This is commit addresses #35. I added a method to validate the username coming in to make sure the google username is used instead.

If the user has a google apps domain (something like jstudent@my.wheaton.edu), the full username should be used. Basically, just checks the string for @gmail.com. Same rules as logging into gmail.

Let me know if I'm missing something or not following your standards. This was just an impulsive commit to a project I just found. I would love to work on this and help out. I love hangouts, but the Google client looks like crap in tiling WMs.

Added a little method to validate the username and make sure the full email isn't used.
Also changed the input label to 'username'.  Fixes #35
@tdryer
Copy link
Owner

tdryer commented Nov 27, 2014

#35 isn't very clear. One user reported not being able to log in with an email address, but an email address should be what users log in with, since this is what the login form asks for, and it'll work the same way for users with a custom domain.

Thanks for your interest though!

@arecker
Copy link
Author

arecker commented Nov 27, 2014

Thanks for looking at it! No problem - totally get it.

@tdryer tdryer closed this Nov 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants