New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging #12

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
2 participants
@Kukkimonsuta
Contributor

Kukkimonsuta commented Nov 21, 2017

  1. as you've found out, you should use dotnet pack or msbuild /t:pack or Pack from rclick menu on project in VS and not nuget.exe
  2. the dependencies you are talking about is just compat layer that should not concern you unless you are still using packages.config (PackageReference is a thing now even in old .csproj), however it is understandable that you want to avoid them either way - which is easily solved:
  • for .NET 4.7+ - target also netstandard2.0
  • for .NET 4.5+ - target also net45
@tdwright

This comment has been minimized.

Show comment
Hide comment
@tdwright

tdwright Nov 21, 2017

Owner

Hi @Kukkimonsuta. Thanks so much for this. I'll get it tested tonight!

Owner

tdwright commented Nov 21, 2017

Hi @Kukkimonsuta. Thanks so much for this. I'll get it tested tonight!

@tdwright tdwright merged commit babf815 into tdwright:master Nov 21, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@tdwright

This comment has been minimized.

Show comment
Hide comment
@tdwright

tdwright Nov 21, 2017

Owner

👍 @Kukkimonsuta

That's working beautifully. I've merged in your commit. Thanks!

Have republished to NuGet: https://www.nuget.org/packages/ConTabs.tdwright/0.1.1

Owner

tdwright commented Nov 21, 2017

👍 @Kukkimonsuta

That's working beautifully. I've merged in your commit. Thanks!

Have republished to NuGet: https://www.nuget.org/packages/ConTabs.tdwright/0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment