New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #13. Table<T>.Create(data) throws PublicPropertiesNotFoundException #18

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
4 participants
@rahl0b10

rahl0b10 commented Dec 19, 2017

Issue #13 describes a bug that can result in unwanted behavior. Classes which serve as data models for table creation and lack public properties would result in the construction of an empty and deformed table. A preferable behavior, as mentioned in the original issue, is to throw an exception which can be properly handled.

Now when an empty list of class properties is returned, and exception is thrown. In order for the exception to be descriptive, a custom exception PublicPropertiesNotFoundException was created. This has been tested and is passing.

@tdwright-itg

Looks good @rahl0b10!

Thanks for making the changes. Much cleaner.

I look forward to working with you again in the future.

Tom

@tdwright tdwright merged commit fbda601 into tdwright:master Dec 19, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@rahl0b10

This comment has been minimized.

Show comment
Hide comment
@rahl0b10

rahl0b10 Dec 19, 2017

@tdwright Great! Thanks for doing your part to keep the open source community enjoyable :)

As an aside, very strange that it's showing the code that was merged as having been contributed by a different (proprietary) account of mine :/ Oh well. lol

rahl0b10 commented Dec 19, 2017

@tdwright Great! Thanks for doing your part to keep the open source community enjoyable :)

As an aside, very strange that it's showing the code that was merged as having been contributed by a different (proprietary) account of mine :/ Oh well. lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment