Skip to content

Find returns false #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ivanovaleksey opened this issue Jul 11, 2017 · 1 comment
Closed

Find returns false #25

ivanovaleksey opened this issue Jul 11, 2017 · 1 comment

Comments

@ivanovaleksey
Copy link
Contributor

Hi @palkan,

Today I have faced with an issue:

Amorail::Lead.find ANY_NONEXISTENT_ID
=> false

I don't it is convenient to return false from #find because one waits for lead instance (if given lead is exists) or nil.

It seems like it occurs because of Entity#handle_response returns false.

My proposal is to return nil instead of false.

What do you think?
@palkan
Copy link
Contributor

palkan commented Jul 11, 2017

Yep, nil is better. Feel free to submit a PR.

ivanovaleksey added a commit to ivanovaleksey/amorail that referenced this issue Jul 11, 2017
@ivanovaleksey
[Fix teachbase#25] Return nil if record is not found
9537b7f
@ivanovaleksey ivanovaleksey mentioned this issue Jul 11, 2017
Merged
@palkan palkan closed this as completed in 624bf8d Jul 12, 2017
ivanovaleksey added a commit to ivanovaleksey/amorail that referenced this issue Jul 18, 2017
@ivanovaleksey
[Fix teachbase#25] Return nil if record is not found
630040c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@palkan @ivanovaleksey