Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readRowsFromSheet is a bit long and ugly #2

Closed
tealeg opened this issue Aug 1, 2011 · 0 comments
Closed

readRowsFromSheet is a bit long and ugly #2

tealeg opened this issue Aug 1, 2011 · 0 comments
Assignees
@tealeg
Milestone
v0.0.4

Comments

@tealeg
Copy link
Owner

tealeg commented Aug 1, 2011

This function is looking a bit hairy now. I should try an break it down a little. In doing so maybe strengthen the tests a little.
@ghost ghost assigned tealeg Aug 1, 2011
tealeg added a commit that referenced this issue Sep 25, 2011
@tealeg
Moved construction of blank row out to seperate function as part of a…
fe870ce 
…ddressing issue #2
tealeg added a commit that referenced this issue Sep 25, 2011
@tealeg
Addressed issue #2 - readRowsFromSheet now managably small and much c…
abbe40b 
…learer
@tealeg tealeg closed this as completed Sep 25, 2011
@ghost ghost mentioned this issue Apr 21, 2015
Closed
tealeg pushed a commit that referenced this issue Apr 1, 2016
Moved construction of blank row out to seperate function as part of a…
a792808 
…ddressing issue #2
tealeg pushed a commit that referenced this issue Apr 1, 2016
Addressed issue #2 - readRowsFromSheet now managably small and much c…
cf575e1 
…learer
tealeg pushed a commit that referenced this issue Oct 24, 2017
@ryho
Merge pull request #2 from ryho/ryanh/Allow_partial_reads
2b55ca8 
Allow partial reads
ryho pushed a commit that referenced this issue Apr 1, 2019
@rentiansheng
Merge pull request #2 from rentiansheng/sheet.row
60f2412 
sheet.row get row by index from sheet issue #388
tealeg added a commit that referenced this issue Jan 14, 2020
@tealeg
Moved construction of blank row out to seperate function as part of a…
4affe33 
…ddressing issue #2
tealeg added a commit that referenced this issue Jan 14, 2020
@tealeg
Addressed issue #2 - readRowsFromSheet now managably small and much c…
1956d81 
…learer
tealeg pushed a commit that referenced this issue Jan 14, 2020
@ryho
Merge pull request #2 from ryho/ryanh/Allow_partial_reads
f3c17af 
Allow partial reads
tealeg pushed a commit that referenced this issue Jan 14, 2020
@rentiansheng
Merge pull request #2 from rentiansheng/sheet.row
1cd9fc4 
sheet.row get row by index from sheet issue #388
tealeg pushed a commit that referenced this issue Jan 14, 2020
@ryho
Merge pull request #2 from ryho/ryanh/Allow_partial_reads
17ea315 
Allow partial reads
tealeg pushed a commit that referenced this issue Jan 14, 2020
@rentiansheng
Merge pull request #2 from rentiansheng/sheet.row
9901870 
sheet.row get row by index from sheet issue #388
tealeg pushed a commit that referenced this issue Jan 14, 2020
@ryho
Merge pull request #2 from ryho/ryanh/Allow_partial_reads
faf3d6d 
Allow partial reads
tealeg pushed a commit that referenced this issue Jan 14, 2020
@rentiansheng
Merge pull request #2 from rentiansheng/sheet.row
1fb7849 
sheet.row get row by index from sheet issue #388
wotmshuaisi pushed a commit to wotmshuaisi/xlsx that referenced this issue Nov 4, 2023
@ryho
Merge pull request tealeg#2 from ryho/ryanh/Allow_partial_reads
f2f4238 
Allow partial reads
wotmshuaisi pushed a commit to wotmshuaisi/xlsx that referenced this issue Nov 4, 2023
@rentiansheng
Merge pull request tealeg#2 from rentiansheng/sheet.row
b766196 
sheet.row get row by index from sheet issue tealeg#388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tealeg tealeg

Labels
None yet
Projects
None yet
Milestone
v0.0.4
Development

No branches or pull requests
1 participant
@tealeg