Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

&umlaut.service_group (formerly collection) #9

Closed
jrochkind opened this Issue · 8 comments

2 participants

@jrochkind
Owner

Custom param &umlaut.collection= to let you specify alternate 'collections' of services on command line.

Should name other than 'collection' be used? 'Collection' is used internally for historical reasons, not what i would have called it today. service_group. service_list?

Maybe umlaut.service_collection to be more clear.

@scotdalton
Owner

Maybe instead of splitting on a comma, we could send an array or service group params, e.g.

resolve?service_group[]=group1&service_group[]=group2&...
@jrochkind
Owner

Would you prefer that?

Even though that's Rails standard, I hate URLs full of that service_group[] nonsense. A simple split-on-commas looks cleaner in the URL (granted, may be irrelevant for OpenURLs that are already ridiculous), and is, I think, more straightforward to create from software other than rails.

What are your reasons to prefer the rails-style array?

Do you see yourself using this built-in functionality, instead of your homegrown stuff? If so, I'll prob defer to what you want, since you'll be using it and not me. :)

@jrochkind
Owner

I'm gonna make it work both ways.

@jrochkind
Owner

Bah, no, doing both is no good.

Scot, you definitely prefer rails-style params to comma-delimited?

@jrochkind
Owner

Man, this is TRICKY to get right.

@scotdalton
Owner

I like that doing a params["umlaut.service_group"] would give you an array and like you said, the OpenURL is pretty unwieldy already. But my preference is not that strong.

@jrochkind
Owner

Merged into master with 7374a1b, accurately described at https://github.com/team-umlaut/umlaut/wiki/Alternate-service-groups

@jrochkind jrochkind closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.