Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remove_result function to proxy action client #66

Merged
merged 1 commit into from Mar 24, 2019

Conversation

@ksm0709
Copy link
Contributor

ksm0709 commented Jan 11, 2019

Similar to #62, I found that proxy action client's 'has_result()' function always return true after I used the result.
For example, in the execute function below,

def execute(self, userdata):
    if self.ac.has_result(self.topic):
        res = self.ac.get_result(self.topic)
        ...

I already used result. but the 'if' statement always activated everytime execute() function called because result is not cleared..

so I think adding remove_result function is needed

@ksm0709 ksm0709 closed this Jan 14, 2019
@ksm0709 ksm0709 reopened this Jan 14, 2019
@pschillinger

This comment has been minimized.

Copy link
Member

pschillinger commented Mar 24, 2019

Thanks for adding and sorry for the delay!

@pschillinger pschillinger changed the base branch from master to develop Mar 24, 2019
@pschillinger pschillinger merged commit 1898ca3 into team-vigir:develop Mar 24, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.