Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to allow multiple proxy connectors? #27

Closed
EugenMayer opened this issue May 20, 2017 · 5 comments
Closed

Any plans to allow multiple proxy connectors? #27

EugenMayer opened this issue May 20, 2017 · 5 comments

Comments

@EugenMayer
Copy link
Contributor

Du to the nature of service-desk you might have a different customer-domain for your service-desk compared to the domain for your "internal" use of jira.

Handling this requires 2 different connector entries, but right now only one is possible.

Shall we make the service.xml be overwriteable by a custom file - one we mount somewhere and copy over on very container start ( needed in case of codebase updates )? This would open a wide range of flexible solutions for customizing server.xml without you being in charge implementing it bit by bit ( though i really like the ENV way..)

@EugenMayer
Copy link
Contributor Author

I see that you are rather manipulating the server.xml https://github.com/blacklabelops/jira/blob/master/imagescripts/docker-entrypoint.sh#L19 not replacing it - this keeps the compatibility high with future releases but makes it hard to deal with this particular feature.

@blacklabelops
Copy link
Member

I never used two connectors inside server.xml. I need an example on what your trying to do.

@EugenMayer
Copy link
Contributor Author

sure. Consider you want to access your jira with 2 different domains: jira.company.de for the internal use and support.company.com for the "servicedesk case" - public facing.

That said, we used 2 different connectors for this

<Connector acceptCount="100" connectionTimeout="20000" disableUploadTimeout="true" enableLookups="false" maxHttpHeaderSize="8192" maxThreads="150" minSpareThreads="25" port="8080" protocol="HTTP/1.1" proxyName="jira.company.de" proxyPort="443" redirectPort="8443" scheme="https" useBodyEncodingForURI="true"/>

<Connector acceptCount="100" connectionTimeout="20000" disableUploadTimeout="true" enableLookups="false" maxHttpHeaderSize="8192" maxThreads="150" minSpareThreads="25" port="18080" protocol="HTTP/1.1" proxyName="support.company.com" proxyPort="443" redirectPort="8443" scheme="https" useBodyEncodingForURI="true"/>

This way you have no issues with jira doing that kind of thing. How do you solve this?

@blacklabelops
Copy link
Member

Looks pretty easy to me.

  • Use xmlstarlet like me to copy the existing connector node.
  • Then use enumerated envs to adjust domain names in both connectors separately at startup.
  • Add another env for specifying the ports.
  • Delete and update connectors at each startup (e.g. deleting all connectors but the first one)

Optional workaround:

  • Add env for specifying a server.xml -> Stops all adjustment by other envs. server.xml must be specified completely.

@blacklabelops
Copy link
Member

Will be implemented in #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants