From fbd92fa3a159f837dca4cbd4ae37a87222156dc7 Mon Sep 17 00:00:00 2001 From: David First Date: Thu, 21 Feb 2019 12:12:38 -0500 Subject: [PATCH 1/2] prevent webpack from resolving packages symlinks in case of custom-resolve-modules. we do need them to stay with the package name so then dependency-tree will filter them as packages and not try to resolve their dependencies --- src/dependency-builder/filing-cabinet/index.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/dependency-builder/filing-cabinet/index.js b/src/dependency-builder/filing-cabinet/index.js index 2845582..0e5e8f9 100644 --- a/src/dependency-builder/filing-cabinet/index.js +++ b/src/dependency-builder/filing-cabinet/index.js @@ -281,6 +281,9 @@ function resolveNonRelativePath(partial, filename, directory, resolveConfig) { if (resolveConfig.modulesDirectories) webpackResolveConfig.modules = resolveConfig.modulesDirectories; if (resolveConfig.aliases) webpackResolveConfig.alias = resolveConfig.aliases; webpackResolveConfig.extensions = resolveExtensions; + // a resolve module might point to an imported component via the package name, in which case + // the package name is a symlink to the imported component. we want it to be resolved as a pkg + webpackResolveConfig.symlinks = false; return resolveWebpack(partial, filename, directory, webpackResolveConfig); } From c5634c6264f5487723ef2f3694bcc32787d84575 Mon Sep 17 00:00:00 2001 From: David First Date: Thu, 21 Feb 2019 14:31:40 -0500 Subject: [PATCH 2/2] bump version --- CHANGELOG.md | 4 ++++ package.json | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fb46bb8..b88b942 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ## [unreleased] +## [2.0.3-dev.2] - 2019-02-21 + +- resolve symlink packages as packages when custom-resolve-modules is used + ## [2.0.3-dev.1] - 2019-02-11 - fix resolve dependencies cache to include parsing errors diff --git a/package.json b/package.json index 5593a28..552d526 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "bit-javascript", - "version": "2.0.3-dev.1", + "version": "2.0.3-dev.2", "scripts": { "flow": "flow; test $? -eq 0 -o $? -eq 2", "lint": "eslint src && flow check || true",