New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "dest" method that behaves similarly to standard gulp dest #22

Merged
merged 5 commits into from Jul 1, 2015

Conversation

Projects
None yet
2 participants
@danrien
Contributor

danrien commented Jun 28, 2015

Added a "dest" method that will behave similarly to the standard gulp dest, based off the sftp('write') method. It will automatically attempt to create folders that don't exist and push according to the glob passed in.

Potential usage: I've been using this to "deploy" my app to a server, like so:

gulp.task('publish-content', ['build-static'], function() {
    return gulp
        .src('./public/**/*')
        .pipe(gulpSsh.dest('/home/protected/app/public/'));
});

Hope you guys find it interesting and/or useful!

@zensh

This comment has been minimized.

Show comment
Hide comment
@zensh

zensh Jun 28, 2015

Member

Hi, you should rebase master for "standard coding style".
It need a simple test case yet.
Thank you for your PR.

Member

zensh commented Jun 28, 2015

Hi, you should rebase master for "standard coding style".
It need a simple test case yet.
Thank you for your PR.

@danrien

This comment has been minimized.

Show comment
Hide comment
@danrien

danrien Jun 30, 2015

Contributor

Hi zensh, I will try to get that tomorrow and re-submit it.

Contributor

danrien commented Jun 30, 2015

Hi zensh, I will try to get that tomorrow and re-submit it.

@danrien

This comment has been minimized.

Show comment
Hide comment
@danrien

danrien Jun 30, 2015

Contributor

Hi zensh, I updated to match your standards (lack of ';' is interesting). I also added a test and updated the test to use a JSON file for configuration if it exists, so that others can run tests easily.

Let me know if you need anything else changed.

Contributor

danrien commented Jun 30, 2015

Hi zensh, I updated to match your standards (lack of ';' is interesting). I also added a test and updated the test to use a JSON file for configuration if it exists, so that others can run tests easily.

Let me know if you need anything else changed.

@danrien

This comment has been minimized.

Show comment
Hide comment
@danrien

danrien Jun 30, 2015

Contributor

Also - I did some research and there is another project - gulp-sftp, that may already have this functionality, but I haven't tested it yet. That may just be the way to go, if you want to keep the scope of this plug-in smaller.

Thanks

Contributor

danrien commented Jun 30, 2015

Also - I did some research and there is another project - gulp-sftp, that may already have this functionality, but I haven't tested it yet. That may just be the way to go, if you want to keep the scope of this plug-in smaller.

Thanks

@danrien danrien closed this Jun 30, 2015

@danrien danrien reopened this Jun 30, 2015

zensh added a commit that referenced this pull request Jul 1, 2015

Merge pull request #22 from danrien/master
Add "dest" method that behaves similarly to standard gulp dest

@zensh zensh merged commit 46fdad1 into teambition:master Jul 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment