Support RSpec 3's deprecation of use of example outside of hooks #1122

Closed
thomas-holmes opened this Issue Jul 20, 2013 · 4 comments

Projects

None yet

2 participants

@thomas-holmes
Contributor

In RSpec 3 the example variable will no longer be defined. It will instead be passed into blocks as an argument. This requires a minor change to Capybara's RSpec.configure before hooks.

I've made a commit with what I think is the change that needs to happen, I'm not sure what branch it should go against though.

See rspec/rspec-core#666 and rspec/rspec-rails#782

@jnicklas jnicklas closed this Jul 21, 2013
@jnicklas jnicklas reopened this Jul 21, 2013
@jnicklas
Collaborator

I accidentally merged and then reverted #1123, which unfortunately broke the build. Let's leave this open for now at least until we find a better solution.

@thomas-holmes
Contributor

Thanks. I opened this up so we could start trying to get this resolved. Hopefully sometime this week we'll have a more complete PR put together.

@thomas-holmes
Contributor

I've got a good PR ready now that I'll be submitting shortly. It should allow rspec-rails to use capybara while having no adverse effects to capybara.

@jnicklas
Collaborator

This is now merged. Thanks!

@jnicklas jnicklas closed this Aug 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment