Support rspec 3 #1125

Merged
merged 1 commit into from Aug 8, 2013

Conversation

Projects
None yet
3 participants
Contributor

thomas-holmes commented Jul 23, 2013

This change addresses issue #1122. This will allow RSpec 3 development to continue working against capybara. This is because example will no longer be explicitly available in hooks.

Contributor

alindeman commented Jul 23, 2013

This looks good to me. rspec-rails master is green under it.

For context, we're deprecating and removing example in favor of it being yielded to the hook as a block argument. To support both RSpec 2 and 3, though, libraries will need to do something like @thomas-holmes's patch.

Thanks ❤️

alindeman added a commit to rspec/rspec-rails that referenced this pull request Jul 23, 2013

capybara supports RSpec 3
* This is a temporary patch until teamcapybara/capybara#1125 is merged

alindeman added a commit to rspec/rspec-rails that referenced this pull request Jul 23, 2013

capybara supports RSpec 3
* This is a temporary patch until teamcapybara/capybara#1125 is merged
Collaborator

jnicklas commented Jul 23, 2013

Could you please squash the commits into one?

Contributor

thomas-holmes commented Jul 23, 2013

There you go.

Contributor

alindeman commented Jul 25, 2013

👍

Contributor

alindeman commented Aug 8, 2013

I know bumps are typically annoying, but any thoughts on this one? I'd love to switch back to mainline capybara in rspec-rails.

@alindeman alindeman referenced this pull request in rspec/rspec-rails Aug 8, 2013

Closed

Think about how the upgrade path will work with Capybara #802

jnicklas added a commit that referenced this pull request Aug 8, 2013

@jnicklas jnicklas merged commit 8bdc7f6 into teamcapybara:master Aug 8, 2013

1 check failed

default The Travis CI build failed
Details
Collaborator

jnicklas commented Aug 8, 2013

looking good.

Contributor

alindeman commented Aug 9, 2013

Great! Any idea when the next release of capybara will be? There's no huge hurry, as we're not yet sure when RSpec 3 will be.

Collaborator

jnicklas commented Aug 9, 2013

We have nothing planned atm, there hasn't really been a lot of activity, lately.

Contributor

alindeman commented Aug 9, 2013

Cool, maybe just some release before we push an rspec 3.0 RC? I can loop back with you when that time comes.

Contributor

alindeman commented Nov 14, 2013

@jnicklas, RSpec 3.0.0 is near! Any chance we can get a capybara release pushed out with this change?

Collaborator

jnicklas commented Nov 14, 2013

Just pushed 2.2.0.rc1. Will push final in a week barring complications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment