Optimization of Capybara::RackTest::Node#unnormalized_text #1309

Merged
merged 1 commit into from May 21, 2014

Projects

None yet

2 participants

@twalpole
Collaborator

Optimize visibility testing of text in Capybara::RackTest::Node#unnormalized_text - Issue #1307

@abotalov
Collaborator

Here is a small benchmark for this - https://gist.github.com/abotalov/c0e2477744b2812ba1ed

Output for current master:

Time for http://www.stackoverflow.com: 0.822666958
Time for http://www.google.com: 0.045470748
Time for http://www.facebook.com: 0.130285212
Time for http://www.github.com: 0.040143588

Output for this branch:

Time for http://www.stackoverflow.com: 0.077864803
Time for http://www.google.com: 0.022559442
Time for http://www.facebook.com: 0.012541807
Time for http://www.github.com: 0.006293787

Improvement is very large.

@twalpole
Collaborator

@abotalov -- Great -- assuming they're producing the same results :) -- Waiting for tests to pass and will then merge

@twalpole twalpole merged commit 3c5dd37 into teamcapybara:master May 21, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment